feat(router): support greedy matches with subsequent static components. #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3888 +/- ##
==========================================
- Coverage 91.41% 91.30% -0.11%
==========================================
Files 162 168 +6
Lines 10281 10666 +385
Branches 2894 3017 +123
==========================================
+ Hits 9398 9739 +341
- Misses 882 926 +44
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Hi @usualoma Great work! Thank you! |
|
This is not a breaking change but I will not include it in a patch rerelease and will include the next minor version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3851
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code